Skip to content

Upstream sync: 2 commits (8598dc3, 304d812)#136

Merged
brunoborges merged 3 commits intomainfrom
copilot/upstream-sync-2-commits
Feb 16, 2026
Merged

Upstream sync: 2 commits (8598dc3, 304d812)#136
brunoborges merged 3 commits intomainfrom
copilot/upstream-sync-2-commits

Conversation

Copy link
Contributor

Copilot AI commented Feb 16, 2026 •
edited
Loading

Syncs 2 commits from github/copilot-sdk (e40d57c...304d812).

Changes

Commit 8598dc3 - Session disposal after client stop

  • Java already implements this protection via synchronized double-dispose check and catches all exceptions (not just specific types like the .NET fix)
  • Added testCloseSessionAfterStoppingClientDoesNotThrow() to verify the scenario

Commit 304d812 - RID fallback for bundled CLI on Linux

  • Not applicable: Java SDK doesn't bundle CLI (users install separately), RID logic is .NET packaging-specific

Housekeeping

  • Updated .lastmerge → 304d812cd4c98755159da427c6701bfb7e0b7c32

Existing Protection

@Override
public void close() {
    synchronized (this) {
        if (isTerminated) return;  // Double-dispose protection
        isTerminated = true;
    }
    try {
        rpc.invoke("session.destroy", ...).get(5, TimeUnit.SECONDS);
    } catch (Exception e) {  // Catches all, not just specific types
        LOG.log(Level.FINE, "Error destroying session", e);
    }
    // ... cleanup
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr list --head copilot/upstream-sync-2-commits tsx server.ts git .0.18-8/x64/bin/git --show-toplevel java nfig/composer/ve--show-toplevel which curl�� grep git p/bin/which --show-toplevel grep de/node/bin/whic--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh pr edit 136 --add-label upstream-sync git cal/bin/which --show-toplevel grep h node ot-s�� server.ts which (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[upstream-sync] Upstream sync: 2 new commits (2026-02-16)</issue_title>
<issue_description>## New Changes Detected

Commit count: 2
Commit range: e40d57c....304d812

Recent commits:

  • 304d812 fix: fall back to portable RID for bundled CLI lookup on Linux (#424) (#482)
  • 8598dc3 Fix ObjectDisposedException when disposing session after client.StopAsync() (#481)

Instructions

@copilot Please follow the agentic-merge-upstream prompt to port these changes to the Java SDK.

Important: When creating the pull request, add the upstream-sync label so the workflow can track progress.

AI generated by Weekly Upstream Sync Agentic Workflow

  • expires on Feb 22, 2026, 3:59 PM UTC

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 16, 2026 16:06
@brunoborges
Add test for closing session after client stops
1796f4c 
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
@brunoborges
Update .lastmerge to 304d812
4a84ca9 
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Copilot AI changed the title [WIP] Sync upstream changes from latest commits Upstream sync: 2 commits (8598dc3, 304d812) Feb 16, 2026
Copilot AI requested a review from brunoborges February 16, 2026 16:11
@brunoborges brunoborges marked this pull request as ready for review February 16, 2026 16:11
@brunoborges brunoborges requested a review from Copilot February 16, 2026 16:14
Copilot AI reviewed Feb 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs 2 commits from the upstream github/copilot-sdk repository. The Java SDK already implements stronger session disposal protection than the .NET SDK fix being synced, so this PR only adds a test to verify the scenario. The second upstream commit (RID fallback for bundled CLI) is not applicable since the Java SDK doesn't bundle the CLI executable.

Changes:

  • Added test to verify session disposal after client stop doesn't throw exceptions
  • Updated .lastmerge to track the latest upstream commit (304d812)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/java/com/github/copilot/sdk/CopilotClientTest.java Adds testCloseSessionAfterStoppingClientDoesNotThrow() to verify robust error handling when closing a session after the client's RPC connection has been closed
.lastmerge Updates upstream sync tracking to commit 304d812cd4c98755159da427c6701bfb7e0b7c32

@brunoborges brunoborges merged commit efdec38 into main Feb 16, 2026
12 checks passed
@brunoborges brunoborges deleted the copilot/upstream-sync-2-commits branch February 25, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@brunoborges brunoborges brunoborges approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brunoborges brunoborges

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[upstream-sync] Upstream sync: 2 new commits (2026-02-16)

3 participants

@brunoborges